denis/configure: inform user when dumping dirty#277
Merged
charliemirabile merged 1 commit intomasterfrom Oct 2, 2025
Merged
Conversation
Merged
charliemirabile
requested changes
Sep 8, 2025
Contributor
charliemirabile
left a comment
charliemirabile
left a comment
There was a problem hiding this comment.
I think it might be cleaner to have the start.py touch a /tmp/reload file every time it reloads and then just compare the mtime from stating the db vs that file so that you don't need to litter the calls to dirty() throughout the whole file relying on the fact that if an update occurs, the db will be written to and have its mtime bumped.
charliemirabile
force-pushed
the
master
branch
from
a073252 to
1a225dd
Compare
theyoyojo
force-pushed
the
dirty_dumping_denis_destroyed
branch
4 times, most recently
from
637f2a6 to
a3281d5
Compare
When the assignment database is altered, the due date waiters must be restarted in order for the new due dates to be operative using: $ denis/configure.sh reload Currently there is no way to know that one has forgotten to run this command. Add a warning message to the output of: $ denis/configure.sh dump to indicate when one has altered the database but not yet operationalized their intentions. Fixes #257 Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
dirty_dumping_denis_destroyed
branch
from
a3281d5 to
b31a752
Compare
charliemirabile
approved these changes
Oct 2, 2025
Contributor
charliemirabile
left a comment
charliemirabile
left a comment
There was a problem hiding this comment.
Re-Ack in light of necessary changes to pass CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the assignment database is altered, the due date waiters must be restarted in order for the new due dates to be operative using:
$ denis/configure.sh reload
Currently there is no way to know that one has forgotten to run this command. Add a warning message to the output of:
$ denis/configure.sh dump
to indicate when one has altered the database but not yet operationalized their intentions.
Fixes #257